Update inconsistent line heights

jpmorganchase · Oct 3, 2024 · d866149 · d866149
1 parent 9edf6c4
commit d866149
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 19 deletions.
diff --git a/.changeset/sixty-elephants-compare.md b/.changeset/sixty-elephants-compare.md
@@ -0,0 +1,5 @@
+---
+"@salt-ds/theme": patch
+---
+
+Inconsistent line-heights were updated.
diff --git a/packages/theme/css/characteristics/text-next.css b/packages/theme/css/characteristics/text-next.css
@@ -52,5 +52,5 @@
   --salt-text-display3-lineHeight: 42px;
 
   --salt-text-display4-fontSize: 24px;
-  --salt-text-display4-lineHeight: 32px;
+  --salt-text-display4-lineHeight: 31px;
 }
diff --git a/packages/theme/css/characteristics/text.css b/packages/theme/css/characteristics/text.css
@@ -83,35 +83,35 @@
 /* Sizes by density */
 .salt-density-touch {
   --salt-text-h1-fontSize: 42px;
-  --salt-text-h1-lineHeight: 54px;
+  --salt-text-h1-lineHeight: 55px;
 
   --salt-text-h2-fontSize: 32px;
   --salt-text-h2-lineHeight: 42px;
 
   --salt-text-h3-fontSize: 24px;
-  --salt-text-h3-lineHeight: 32px;
+  --salt-text-h3-lineHeight: 31px;
 
   --salt-text-h4-fontSize: 16px;
-  --salt-text-h4-lineHeight: 20px;
+  --salt-text-h4-lineHeight: 21px;
 
   --salt-text-label-fontSize: 14px;
   --salt-text-label-lineHeight: 18px;
 
   --salt-text-fontSize: 16px;
-  --salt-text-lineHeight: 20px;
-  --salt-text-minHeight: 20px;
+  --salt-text-lineHeight: 21px;
+  --salt-text-minHeight: 21px;
 
   --salt-text-display1-fontSize: 84px;
   --salt-text-display1-lineHeight: 109px;
 
   --salt-text-display2-fontSize: 58px;
-  --salt-text-display2-lineHeight: 76px;
+  --salt-text-display2-lineHeight: 75px;
 
   --salt-text-display3-fontSize: 42px;
-  --salt-text-display3-lineHeight: 54px;
+  --salt-text-display3-lineHeight: 55px;
 
   --salt-text-display4-fontSize: 42px;
-  --salt-text-display4-lineHeight: 54px;
+  --salt-text-display4-lineHeight: 55px;
 
   --salt-text-notation-fontSize: 14px;
   --salt-text-notation-lineHeight: 18px;
@@ -122,10 +122,10 @@
   --salt-text-h1-lineHeight: 42px;
 
   --salt-text-h2-fontSize: 24px;
-  --salt-text-h2-lineHeight: 32px;
+  --salt-text-h2-lineHeight: 31px;
 
   --salt-text-h3-fontSize: 18px;
-  --salt-text-h3-lineHeight: 24px;
+  --salt-text-h3-lineHeight: 23px;
 
   --salt-text-h4-fontSize: 14px;
   --salt-text-h4-lineHeight: 18px;
@@ -155,10 +155,10 @@
 
 .salt-density-medium {
   --salt-text-h1-fontSize: 24px;
-  --salt-text-h1-lineHeight: 32px;
+  --salt-text-h1-lineHeight: 31px;
 
   --salt-text-h2-fontSize: 18px;
-  --salt-text-h2-lineHeight: 24px;
+  --salt-text-h2-lineHeight: 23px;
 
   --salt-text-h3-fontSize: 14px;
   --salt-text-h3-lineHeight: 18px;
@@ -180,18 +180,18 @@
   --salt-text-display2-lineHeight: 47px;
 
   --salt-text-display3-fontSize: 24px;
-  --salt-text-display3-lineHeight: 32px;
+  --salt-text-display3-lineHeight: 31px;
 
   --salt-text-display4-fontSize: 24px;
-  --salt-text-display4-lineHeight: 32px;
+  --salt-text-display4-lineHeight: 31px;
 
   --salt-text-notation-fontSize: 10px;
   --salt-text-notation-lineHeight: 13px;
 }
 
 .salt-density-high {
   --salt-text-h1-fontSize: 18px;
-  --salt-text-h1-lineHeight: 24px;
+  --salt-text-h1-lineHeight: 23px;
 
   --salt-text-h2-fontSize: 14px;
   --salt-text-h2-lineHeight: 18px;
@@ -210,16 +210,16 @@
   --salt-text-minHeight: 14px;
 
   --salt-text-display1-fontSize: 42px;
-  --salt-text-display1-lineHeight: 54px;
+  --salt-text-display1-lineHeight: 55px;
 
   --salt-text-display2-fontSize: 28px;
   --salt-text-display2-lineHeight: 36px;
 
   --salt-text-display3-fontSize: 18px;
-  --salt-text-display3-lineHeight: 24px;
+  --salt-text-display3-lineHeight: 23px;
 
   --salt-text-display4-fontSize: 18px;
-  --salt-text-display4-lineHeight: 24px;
+  --salt-text-display4-lineHeight: 23px;
 
   --salt-text-notation-fontSize: 8px;
   --salt-text-notation-lineHeight: 10px;