Versioning and publishing packages

[NMinhNguyen]

Consider adding https://github.com/atlassian/changesets (see #1 (comment))

[sebinsua]

I think we consider this at some point, but not until we are ready to publish packages.

[threepointone]

Since we're now looking at primarily working inside one repo where workspace packages won't be getting published, this isn't as useful as one would image, and as such shouldn't be considered core. Happy to reopen or make a fresh issue later if the actual need comes up.

[sebinsua]

I'm going to re-open this since it's noticeably awkward to build and publish right now without any automation.

For example, within the E2E tests, I had to hardcode package names:

modular/e2e-tests/core.test.ts

Lines 90 to 124 in 1fd6cb2

	// Build and publish packages to the local registry.
	for (const packageName of [
	'cra-template-modular-typescript',
	'create-modular-react-app',
	'eslint-config-modular-app',
	'modular-scripts',
	'modular-template-widget-typescript',
	]) {
	try {
	await execa('yarn', ['workspace', packageName, 'build']);
	} catch (error) {
	// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
	if (error.stderr && error.stderr.includes('Command "build" not found.')) {
	console.debug(
	`No "build" script found for ${packageName}. Skipping...`,
	);
	} else {
	throw error;
	}
	}
	await execa(
	'yarn',
	[
	'workspace',
	packageName,
	'publish',
	'--registry',
	LOCAL_VERDACCIO_REGISTRY,
	'--no-git-tag-version',
	'--non-interactive',
	'--patch',
	],
	{ stdio: 'inherit' },
	);
	}

I'm thinking of installing manypkg and changesets.

[NMinhNguyen]

Since we're now looking at primarily working inside one repo where workspace packages won't be getting published, this isn't as useful as one would image, and as such shouldn't be considered core. Happy to reopen or make a fresh issue later if the actual need comes up.

I think the reason this issue was closed is actually not right anyway. The point of this issue was to automate versioning and publishing of modular-scripts and all of the packages in this repo. It's not about enabling publishing in a monorepo created by create-modular-react-app.

[threepointone]

My bad, sorry!

[threepointone]

(Besides, my original point doesn’t stand either, since we’re now going to publish packages too)

[NMinhNguyen]

(Besides, my original point doesn’t stand either, since we’re now going to publish packages too)

Packages in the modular-created monorepo or in standalone repos for consumption by the monorepo?

[threepointone]

modular created repos (per “modular for libs”)