-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce sass skins #260
Introduce sass skins #260
Conversation
Was just reviewing. Why has so much of the CSS file changed without actually changing? |
That's just a first step :) |
Let me put it another way... I do not mind having sass setup, but why did it go and change the original CSS I wrote. Fair enough, it can go and create its own .scss files, but leave my files alone. |
Well, because the main purpose of sass is to generate css files :) |
I thought I'd see what others thought first, but apparently no one cares, except you and now me. I will be merging this pull request to give you the nod, but I will refactor it somewhat. The skin files will now be compiled by SASS into the |
Having just reviewed the changes you make and the way you did it, I would rather go about it a different way. I want to commit each step:
I'd then move what remains of the old I would then update all the demos to point at the new place... Then probably push to 2.9.2 - and yes it counts as a restructure, but if I updated the major version every time I changed the structure, we would be in double figures by now. |
Yeah man ! |
This is now in master and will go into the next 2.9.2 tag when I polish off the circle player changes. |
Woops, i just realized sass files are not included in npm package :) Would you ? |
No description provided.