Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicking on match opening wrong match #1984

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Sep 12, 2024

There was a bug introduced when adding file sorting, that sometimes the wrong file was opened for a match.

The reason for this was that the index search was performed on the unsorted list, but the opening of the comparisons was done on a sorted list

@Kr0nox Kr0nox changed the title Fix cliking on match opening wrong match Fix clicking on match opening wrong match Sep 12, 2024
@Kr0nox Kr0nox requested a review from a team September 12, 2024 14:46
Copy link

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Sep 13, 2024
@tsaglam tsaglam added this to the 6.0.0 milestone Sep 13, 2024
@tsaglam tsaglam merged commit e56bae4 into develop Sep 13, 2024
51 checks passed
@tsaglam tsaglam deleted the report-viewer/match-click-bug branch September 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants