Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file sorting #1891

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Add file sorting #1891

merged 6 commits into from
Aug 2, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jul 27, 2024

This PR adds a selector at the top of the comparison view to the top of the comparison view.
grafik
Files can be sorted

  • Alphabetically
  • By the percent of tokens that are part of a match
  • The number of matches in a file
  • The size of the matches in the files

Kr0nox added 5 commits July 6, 2024 11:12
@Kr0nox
add sorting to model
e07157e
@Kr0nox
add selector
653fb66
@Kr0nox
basic file sorting
1ac7419
@Kr0nox
move to soring by calling exposed function
2d9e4f6
@Kr0nox
Merge remote-tracking branch 'origin/develop' into report-viewer/file…
afe6897 
…-sorting

# Conflicts:
#	report-viewer/src/components/fileDisplaying/FilesContainer.vue
#	report-viewer/src/views/ComparisonView.vue
@Kr0nox Kr0nox added this to the 6.0.0 milestone Jul 27, 2024
@Kr0nox Kr0nox linked an issue Jul 27, 2024 that may be closed by this pull request
Add default file sorting options #1605
Closed
@Kr0nox Kr0nox added report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies enhancement Issue/PR that involves features, improvements and other changes labels Jul 27, 2024
@Kr0nox Kr0nox requested review from TwoOfTwelve and a team July 29, 2024 10:27
tsaglam
tsaglam approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment regarding tooltips, but besides that it is ready to merge.

report-viewer/src/model/ui/FileSortingOptions.ts Outdated Show resolved Hide resolved
@Kr0nox @tsaglam
Update Tooltips
4e32d90 
Co-authored-by: Timur Sağlam <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam
Copy link
Member

tsaglam commented Aug 2, 2024

@TwoOfTwelve ready from your side?

@tsaglam tsaglam merged commit a0a6233 into develop Aug 2, 2024
49 checks passed
@tsaglam tsaglam deleted the report-viewer/file-sorting branch August 2, 2024 14:01
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoOfTwelve TwoOfTwelve TwoOfTwelve approved these changes

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Add default file sorting options
3 participants
@Kr0nox @tsaglam @TwoOfTwelve