-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid progress bar overlap #1866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few issues regarding sync and naming here. Also, please check the Sonar issues.
… into feature/avoidProgressBarOverlap
Both would be possible. Without the duplication, it looks cleaner. With the duplication, you get feedback earlier. For large datasets, this allows you to already check out the erroneous submissions while JPlag is still running. @jplag/hiwi @jplag/maintainer any preferences? |
I think printing them after (and thus having no duplication) would be better.
But that is just my opinion. Feel free to object |
Can you try again. Now there should be nothing cut of. |
Quality Gate passed for 'JPlag Plagiarism Detector'Issues Measures |
This seems to be fixed now
@TwoOfTwelve Did you also change it to this behavior? Or was it the default in your PR anyways or is my dataset just small enough that the errors are printed so late? |
With the way it's implemented in this PR the error will always be printed after the progress bar has reach 100% or JPlag was aborted. I could try to change that behavior by interrupting the progress bar when an error occurs, but that would be a lot more work. |
Avoids overlaps of the progress bar with log outputs by delaying the log outputs while a progress bar is being shown.
Log outputs that happen during the progress bar are instead shown below it, after it is done:
There is still some overlap with antlr, because antlr writes directly to System.err. That problem is addressed in #1868.