Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch all Exceptions in java #1768

Merged
merged 1 commit into from
May 22, 2024
Merged

Catch all Exceptions in java #1768

merged 1 commit into from
May 22, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented May 17, 2024

When a generic exception was thrown whilst parsing java code, it was not possible to easily identify the failed submission.
Exceptions now get wrapped in parsing exceptions.

Fixes #1720

@Kr0nox Kr0nox requested review from TwoOfTwelve and a team May 17, 2024 12:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels May 17, 2024
@Kr0nox Kr0nox added this to the 5.1.0 milestone May 18, 2024
@tsaglam tsaglam merged commit 38fb673 into develop May 22, 2024
44 checks passed
@tsaglam tsaglam deleted the bug-fix/java-exception branch May 22, 2024 06:50
@github-actions github-actions bot mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuchss dfuchss dfuchss approved these changes

@TwoOfTwelve TwoOfTwelve Awaiting requested review from TwoOfTwelve

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Kr0nox @dfuchss @tsaglam