Fix superlinear regex #1736
Merged
Fix superlinear regex #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kr0nox
added
bug
|
TwoOfTwelve
approved these changes
May 2, 2024
tsaglam
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report viewer was operating with a regex that is vulnerable to superlinear runtime. In theory this should never by a problem, since it is only used in file parsing and thus does not operate on user data. In practice this change can decrease the runtime of the zip parsing, even if it is only slightly.
The check whether the folder name is
submissionscould be removed, since it was last used in version 4.1.0 which is not supported by the current report viewer@tsaglam @TwoOfTwelve @uuqjz could you quickly verify that the report viewer with this change works with reports generated under your respective operating systems