Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show hover text all the time #1646

Merged
merged 2 commits into from
Mar 13, 2024
Merged

show hover text all the time #1646

merged 2 commits into from
Mar 13, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Mar 12, 2024

The text on the cluster graph has two bugs:

  • The text stating that you could hover over eged was hidden when all comparisons were included in the report
  • The text could be cut off, if the window had the wrong format, since the cluster took the whole height.

These two are now fixed

@Kr0nox Kr0nox added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Mar 12, 2024
@Kr0nox Kr0nox requested a review from sebinside March 12, 2024 13:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam merged commit 5178584 into develop Mar 13, 2024
40 checks passed
@tsaglam tsaglam deleted the report-viewer/fix-cluster-text branch March 13, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

@sebinside sebinside Awaiting requested review from sebinside

Assignees
No one assigned
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kr0nox @tsaglam