Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete system e2e test #1631

Merged
merged 12 commits into from
Mar 6, 2024
Merged

Complete system e2e test #1631

merged 12 commits into from
Mar 6, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Mar 1, 2024

This PR overhauls the report viewer e2e tests and executes them in combination with the cli as discussed in #1598

Workflow

The workflow first builds JPlag. This is only done once.
Then over a matrix conversation we run Jplag on different datasets on 3 different OS (windows, macos, ubuntu)
At the end the end-to-end tests get run on all systems.

Changes to e2e Tests

  • General e2e tests now run with the progpedia dataset. Tests were adjusted accordingly.
  • Due to Can not unhide Names with spaces in them #1629 the parts checking name hiding are disabled.
  • Cluster tests still run with a static dataset, to have them deterministic

Check different input types

In addition to the old e2e test. There is a parametrized test that checks that comparisons are openable.
We check:

  • Submission Folder with only one root
  • Submission Folder with multiple root
  • Files without submission folders with single root
  • Files without submission folders with multiple root (Currently disabled due to [bug] File structure discrepancy  #1610

@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Mar 1, 2024
@Kr0nox Kr0nox linked an issue Mar 1, 2024 that may be closed by this pull request
@Kr0nox Kr0nox requested a review from sebinside March 2, 2024 08:10
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sebinside sebinside merged commit 1b0c11d into develop Mar 6, 2024
36 checks passed
@sebinside sebinside deleted the feature/complete-e2e branch March 6, 2024 11:52
@Kr0nox Kr0nox mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete end to end test
2 participants