-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete system e2e test #1631
Merged
Merged
Complete system e2e test #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kr0nox
added
the
report-viewer
PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
label
Mar 1, 2024
Quality Gate passed for 'JPlag Report Viewer'Issues Measures |
sebinside
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
report-viewer
PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls the report viewer e2e tests and executes them in combination with the cli as discussed in #1598
Workflow
The workflow first builds JPlag. This is only done once.
Then over a matrix conversation we run Jplag on different datasets on 3 different OS (windows, macos, ubuntu)
At the end the end-to-end tests get run on all systems.
Changes to e2e Tests
Check different input types
In addition to the old e2e test. There is a parametrized test that checks that comparisons are openable.
We check: