ImmediatlyWriteZip #1416
Merged
ImmediatlyWriteZip #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of creating single files.
TwoOfTwelve
requested review from
tsaglam and
Kr0nox
and removed request for
tsaglam
|
Should fix #1212 |
tsaglam
added
enhancement
|
As discussed, let's test how the performance is changed for a larger data set and include it in the PR description. |
tsaglam
requested changes
Dec 13, 2023
| @@ -76,10 +77,10 @@ public static void main(String[] args) { | |||
| if (!parseResult.isUsageHelpRequested() && !(parseResult.subcommand() != null && parseResult.subcommand().isUsageHelpRequested())) { | |||
| JPlagOptions options = cli.buildOptionsFromArguments(parseResult); | |||
| JPlagResult result = JPlag.run(options); | |||
| ReportObjectFactory reportObjectFactory = new ReportObjectFactory(); | |||
| reportObjectFactory.createAndSaveReport(result, cli.getResultFolder()); | |||
| ReportObjectFactory reportObjectFactory = new ReportObjectFactory(new File(cli.getResultFolder() + ".zip")); | |||
There was a problem hiding this comment.
Why is ".zip" hardcoded here? I think this should be part of the factory and probably a constant.
core/src/main/java/de/jplag/reporting/jsonfactory/ComparisonReportWriter.java
Outdated
Show resolved
Hide resolved
core/src/test/java/de/jplag/reporting/reportobject/ReportObjectFactoryTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/de/jplag/reporting/reportobject/ReportObjectFactoryTest.java
Outdated
Show resolved
Hide resolved
|
What is the wanted behaviour, if jplag cant write the zip (can for example be forced by having a zip with the same name open). |
Kr0nox
reviewed
Dec 15, 2023
core/src/main/java/de/jplag/reporting/jsonfactory/ComparisonReportWriter.java
Show resolved
Hide resolved
tsaglam
approved these changes
Jan 25, 2024
|
@TwoOfTwelve we have one conflict here. |
tsaglam
requested changes
Feb 2, 2024
# Conflicts: # cli/src/main/java/de/jplag/cli/CLI.java # core/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java
tsaglam
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the report object factory to immediately write to a zip file instead of creating single files.
I tried to check how the runtime changed, by running jplag over 100 copies of the jplag code.
This is the result:
old:
8:10.19
7224.86s user 29.80s system
new:
7:46.55
6893.25s user 28.17s system
The majority of the time however was spent on comparing the submissions, so this might not be representative.
I build an artificial "worst-case" scenario to check the speed and both the old and the new version took the same time.