Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting and filtering on cluster table #1413

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Sorting and filtering on cluster table #1413

merged 2 commits into from
Dec 8, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Dec 5, 2023

This PR adds the ability to search and filter the table in the cluster view.

For this code was moved around.

  • The searchbar and sorting options were moved into the their own component.
    • This component is used in the comparison table component
  • The filtering and sorting methods were moved from the overview to the comparison table component

@Kr0nox Kr0nox requested a review from sebinside December 5, 2023 09:10
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Dec 5, 2023
@sebinside sebinside removed the enhancement Issue/PR that involves features, improvements and other changes label Dec 5, 2023
@tsaglam tsaglam added minor Minor issue/feature/contribution/change enhancement Issue/PR that involves features, improvements and other changes labels Dec 5, 2023
@tsaglam tsaglam self-requested a review December 5, 2023 15:14
tsaglam
tsaglam approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this looks good.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit 4582345 into develop Dec 8, 2023
21 checks passed
@tsaglam tsaglam deleted the report-viewer/better-cluster-table branch December 8, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

@sebinside sebinside Awaiting requested review from sebinside

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kr0nox @tsaglam @sebinside