Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve eslint #1407

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Improve eslint #1407

merged 2 commits into from
Dec 2, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Nov 30, 2023

This PR makes sure there are no warnings in the code. otherwise the pre-commit hook and the workflow fail

@Kr0nox Kr0nox requested a review from sebinside November 30, 2023 11:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2023

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dfuchss dfuchss merged commit c5c4441 into develop Dec 2, 2023
21 checks passed
@dfuchss dfuchss deleted the report-viewer/better-lint branch December 2, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuchss dfuchss dfuchss approved these changes

@sebinside sebinside Awaiting requested review from sebinside

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kr0nox @dfuchss