Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add normalization info to cpp tokens #1371

Merged
merged 10 commits into from
Nov 27, 2023
Merged

Add normalization info to cpp tokens #1371

merged 10 commits into from
Nov 27, 2023

Conversation

brodmo
Copy link
Contributor

@brodmo brodmo commented Nov 7, 2023 •
edited
Loading

Enables using token string normalization for CPP code (didn't test thoroughly for effectiveness, but stability is given).
I also changed some other, minor things which should be merged:

  • Added logging for normalization and fixed mistaken usage of java.util.Logger
  • Normalization is no longer performed in-place and instead returns a new array
  • Added extra checks in grammar handling to avoid crashes in special cases
  • Split cpp TRY token into TRY_BEGIN and TRY_END

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change labels Nov 8, 2023
@tsaglam
Copy link
Member

tsaglam commented Nov 8, 2023

I also changed some other, minor things which should be merged.

@mbrdl Can you briefly elaborate on these changes in the PR description?

@tsaglam tsaglam added the language PR / Issue deals (partly) with new and/or existing languages for JPlag label Nov 8, 2023
@brodmo
Copy link
Contributor Author

brodmo commented Nov 24, 2023

@tsaglam Done

tsaglam
tsaglam approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment.

core/src/main/java/de/jplag/Submission.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.5% 96.5% Coverage
0.2% 0.2% Duplication

@brodmo brodmo requested a review from tsaglam November 26, 2023 19:20
@tsaglam tsaglam merged commit e2d8bb7 into jplag:develop Nov 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag major Major issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brodmo @tsaglam