Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme in result zip file #1361

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Readme in result zip file #1361

merged 8 commits into from
Dec 1, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Oct 30, 2023

This PR adds a README.txt to the generated result.zip.

To enable this slight changes to the file writing were made. Currently the file Writers only support JSON files. A new Writer was added to enable wirting strings to files.

The content of this file should be discussed here/in a meeting.

@Kr0nox Kr0nox requested review from tsaglam and TwoOfTwelve October 30, 2023 13:08
@Kr0nox Kr0nox added this to the v5.0.0 milestone Oct 31, 2023
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just one thing to consider.

@Kr0nox Kr0nox requested a review from TwoOfTwelve November 16, 2023 13:10
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Nov 22, 2023
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor things.

@Kr0nox Kr0nox requested a review from tsaglam November 27, 2023 14:40
Copy link

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@tsaglam

This comment was marked as outdated.

@tsaglam tsaglam merged commit 96ad012 into develop Dec 1, 2023
10 checks passed
@tsaglam tsaglam deleted the feature/report-readme branch December 1, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants