Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve information on overview #1339

Merged
merged 2 commits into from
Nov 10, 2023
Merged

improve information on overview #1339

merged 2 commits into from
Nov 10, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Oct 13, 2023

This PR improves the information shown on the overview, by:

  • Stating both the shown and total comparisons
  • Adding a tooltip on the shwon/total comparisons, refering to the coresponding CLI flag
  • Adding a tooltip on the min match length, refering to the coresponding CLI flag

@Kr0nox Kr0nox requested a review from sebinside October 13, 2023 09:27
@Kr0nox Kr0nox added this to the v5.0.0 milestone Oct 27, 2023
@Kr0nox Kr0nox marked this pull request as draft October 31, 2023 15:52
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kr0nox Kr0nox marked this pull request as ready for review November 1, 2023 14:23
@Kr0nox Kr0nox linked an issue Nov 1, 2023 that may be closed by this pull request
Inconsistent terminology in Report Viewer #1278
Closed
4 tasks
@Kr0nox Kr0nox requested a review from tsaglam November 3, 2023 20:59
@tsaglam tsaglam merged commit f0e2e49 into develop Nov 10, 2023
17 checks passed
@tsaglam tsaglam deleted the report-viewer/improve-overview branch November 10, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

@sebinside sebinside Awaiting requested review from sebinside

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

Inconsistent terminology in Report Viewer
2 participants
@Kr0nox @tsaglam