Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance comparison table #1331

Merged
merged 8 commits into from
Nov 30, 2023
Merged

Enhance comparison table #1331

merged 8 commits into from
Nov 30, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Oct 10, 2023

This PR adds 3 small enhancements for the report viewers comparison table.

  • In the Comparison View there now is an option to sort by Cluster. This method works by grouping all shown comparisons in a cluster toghether in the table. Inside the cluster submissions are sorted by their average similaritys. All clusters are sorted by their average similarity. All submissions that are not part of a cluster are shown below the clusters, also sorted by their average similarity
  • It is now possible to hide and show usernames directly in the table. When hovering over a name in table it now shows an eye (or an eye with a slash) and clicking it will hide/show that name.
  • It is now possible to insert content into a slot below the comparison table. This is currently used to display warnings, regarding missing comparisons due to the limit set in the CLI

@Kr0nox Kr0nox requested a review from sebinside October 10, 2023 15:58
@sonarqubecloud
Copy link

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kr0nox Kr0nox added this to the v5.0.0 milestone Oct 10, 2023
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Nov 22, 2023
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the changes. However, the sorting by cluster did behave somewhat intuitively when tested with real world data. We should this discuss in the next meeting.

@Kr0nox
Copy link
Member Author

Kr0nox commented Nov 28, 2023

@sebinside It should behave like expected now.
The issue was that I first sorted by the similarity and then by the index of the cluster, so in the end the table was just sorted by the index. Switching them around should have solved the problem. Can you confirm thtat?

…ance-table

# Conflicts:
#	report-viewer/src/views/ClusterView.vue
Copy link

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kr0nox Kr0nox merged commit 04b89d2 into develop Nov 30, 2023
13 checks passed
@Kr0nox Kr0nox deleted the report-viewer/enchance-table branch November 30, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants