-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new color generation for matches #1311
Conversation
We should take a look at the list of colors in the next dev meeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, the new colors look great with real data! I only have minor and easy to implement change requests, please see the comments above.
I changed it. Could you have a quick look to make sure the two oranges are not too similar @sebinside |
[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The colors look great, thank you!
This PR changes the color generation for matches.
Instead of distributing the colors across the hue spectrum, now there is a set of 7 (handpicked) colors from which each match is colored.
The algortihm for choosing colors: First all matches get sorted 3 times. (By line number in first and second submission and by number of tokens). It then runs through the list of matches and chooses the first color it can find that is not neigboring this match in any of the three lists. To avoid having only the first few colors or even only two alternating colors, we dont start with the first color when having found a fitting color but go on with the next in the list and go through the list cyclical.