Add Typescript language module #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # languages/cpp2/src/test/java/de/jplag/cpp2/TokenExtractionTest.java
# Conflicts: # languages/text/src/test/java/jplag/text/NaturalLanguageTest.java
# Conflicts: # README.md # cli/pom.xml # coverage-report/pom.xml # languages/pom.xml
tsaglam
added
enhancement
dfuchss
reviewed
Aug 24, 2023
languages/typescript/src/main/java/de/jplag/typescript/grammar/TypeScriptLexerBase.java
Show resolved
Hide resolved
sebinside
reviewed
Aug 24, 2023
TwoOfTwelve
requested changes
Sep 5, 2023
languages/typescript/src/main/java/de/jplag/typescript/TypeScriptLanguageOptions.java
Outdated
Show resolved
Hide resolved
languages/typescript/src/test/java/de/jplag/typescript/JavaScriptLanguageTest.java
Outdated
Show resolved
Hide resolved
TwoOfTwelve
approved these changes
Sep 5, 2023
dfuchss
reviewed
Sep 5, 2023
|
If the last issue is resolved, I think the PR would be ready to merge. Is this correct @Kr0nox ? :) |
|
@sebinside wanted to have a look at the choice of tokens. I dont know if he did that already |
sebinside
approved these changes
Sep 6, 2023
|
[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a language module for parsing TypeScript and JavaScript.
Since the grammar specifies no version, but code from TS v5 can be parsed (tho no tokens are extracted) the version is estimated to be v5.
The token extraction is inspired by Java and Python