Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the @TempDir annotation, since it caused some warnings #1221

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Removed the @TempDir annotation, since it caused some warnings #1221

merged 1 commit into from
Aug 7, 2023

Conversation

TwoOfTwelve
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve commented Aug 5, 2023 •
edited by tsaglam
Loading

Removed the @tempdir annotation as it lead to build issues on windows systems. Replaced by File.createTempFile.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2023

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TwoOfTwelve TwoOfTwelve requested a review from tsaglam August 5, 2023 18:37
@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Aug 7, 2023
@tsaglam tsaglam merged commit 539aa13 into develop Aug 7, 2023
@tsaglam tsaglam deleted the feature/remove-tempdir-annotation branch August 7, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoOfTwelve @tsaglam