Merge pull request #1973 from jplag/report-viwer/better-cluster-edges

Reduce misleading of cluster edges
jplag · Sep 9, 2024 · 29e90a7 · 29e90a7
2 parents 1a1b1bb + 666f849
commit 29e90a7
Showing 1 changed file with 19 additions and 7 deletions.
diff --git a/report-viewer/src/components/ClusterGraph.vue b/report-viewer/src/components/ClusterGraph.vue
@@ -165,33 +165,45 @@ const maximumSimilarity = computed(() => {
   return maximumSimilarity
 })
 
-function getClampedSimilarityFromKeyIndex(firstIndex: number, secondIndex: number) {
+function getClampedSimilarityFromKeyIndex(
+  firstIndex: number,
+  secondIndex: number,
+  min: number,
+  max: number
+) {
   const similarity = getSimilarityFromKeyIndex(firstIndex, secondIndex)
   if (similarity == 0) {
     return 0
   }
-  if (minimumSimilarity.value == maximumSimilarity.value) {
+  if (min == max) {
     return 1
   }
-  return (
-    (similarity - minimumSimilarity.value) / (maximumSimilarity.value - minimumSimilarity.value)
-  )
+  return (similarity - min) / (max - min)
 }
 
 function getEdgeAlphaFromKeyIndex(firstIndex: number, secondIndex: number) {
   const similarity = getSimilarityFromKeyIndex(firstIndex, secondIndex)
   if (similarity == 0) {
     return 1
   }
-  return getClampedSimilarityFromKeyIndex(firstIndex, secondIndex) * 0.7 + 0.3
+  return (
+    getClampedSimilarityFromKeyIndex(
+      firstIndex,
+      secondIndex,
+      Math.min(minimumSimilarity.value, 0.5),
+      maximumSimilarity.value
+    ) *
+      0.7 +
+    0.3
+  )
 }
 
 function getEdgeWidth(firstIndex: number, secondIndex: number) {
   const similarity = getSimilarityFromKeyIndex(firstIndex, secondIndex)
   if (similarity == 0) {
     return 0.5
   }
-  return getClampedSimilarityFromKeyIndex(firstIndex, secondIndex) * 5 + 1
+  return getClampedSimilarityFromKeyIndex(firstIndex, secondIndex, 0, 1) * 5 + 1
 }
 
 function getEdgeDashStyle(firstIndex: number, secondIndex: number) {