Add support for PHP 7.1 DateTime::setTime with microseconds #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hising
commented
Apr 10, 2017
hising
commented
- Added $microseconds with default set to 0 as argument
- Added test for making sure setTime with and without microseconds generate same output
|
Thanks, looks fine by me. Although the |
|
Or in |
|
Why still not merged? |
|
@IAkumaI I guess it is up to the maintainers to do check and merge. I haven't poked them, I see that there are more pull requests solving the same problem. A temporary solution could be to override the class in your local code I guess? |
|
@hising My temporary solutions is editing file in vendor directory. Hard and stupid, but works ) |
AlexPerov
pushed a commit
to AlexPerov/php-activerecord
that referenced
this pull request
Nov 20, 2019
…s2#568) * Add microseconds to setTime to support PHP 7.1 * Add test for setTime with microseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.