Add info on skipped tests and how to fix them #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you mention the |
|
Good idea -- done. |
|
@louismrose hi, thanks for your contribution! Unfortunately not, which causes PR's to linger for long periods of time.. Especially PR's around (mayor) code changes, like #430, which has been around for ages now.. Anyway, your changes are scoped to OSX (
|
|
@koenpunt Thanks for the clarification: good to know! I've made the changes you suggest (and future proofed them by referring to the Apple OS as macOS). |
|
Thanks! 👍 |
louismrose
added a commit
to zamzar/php-activerecord
that referenced
this pull request
Sep 23, 2016
* Add info on skipped tests and how to fix them * Detail PHPAR env vars in contribution docs. * Clarifies that brew commands are for macOS
AlexPerov
pushed a commit
to AlexPerov/php-activerecord
that referenced
this pull request
Nov 20, 2019
* Add info on skipped tests and how to fix them * Detail PHPAR env vars in contribution docs. * Clarifies that brew commands are for macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a few issues getting the test suite to run to completion on my machine, so I've taken the liberty of adding a few notes to the contributors documentation.
If these look reasonable, would it be worth merging them into the main repo?