-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service: support sending a slash command #57
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] channels
This seems only an issue for IM channels. However there isn't a `excludeArchived` for IM channels. So we will only add users that aren't deleted to the UserCache. When we are adding the IM channels we will check if the name is present in the UserCache, when it isn't we will ignore it. Resulting in channels without IM channels that are from delete users. Fixes jpbruinsslot#3
Fixes jpbruinsslot#13 For instance the github integration doesn't have a discoverable username, so this will become unkown. Some integrations with attachment fields, title and text should be tested for the correct order.
This should alleviate some problems with using the application and getting the error: panic: runtime error: slice bounds out of range However, I'm still able to trigger this event when scrolling the mouse wheel. Fixes jpbruinsslot#47
In order to fix issue jpbruinsslot#47 I've added a custom eventstream to termui that will deregister its own eventstream. This will ensure me that the events will not be sent to termui's (unbuffered) event channel and will be picked up by the buffered termbox channel of slack-term. Fixes jpbruinsslot#47
This will add: * An icon for channels * An icon for groups * An icon for im channels It will also add an icon that identifies the presence of a user. Fixes jpbruinsslot#44
* search-channel: Add search functionality
Not able to make it work for now, artifacts from prior chat view are visible next to the emoji's because of width being greater than 1. Filling the width of the cell with spaces didn't work unfortunately. Neither did clearing the buffer or rewriting the whole screen blank.
* Terminal is now returned to normal when quitting * Fix resize handler * Update structure event handling
This was referenced Aug 3, 2017
Closed
@erroneousboat why was this closed? |
I have no idea, perhaps it happened when I rewrote the repository in order to remove some large binaries that were still present. |
@erroneousboat oh I see, I'll re-create it later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires https://github.com/nlopes/slack/pull/176 to be merged.