Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ogt_vox: split fatal errors and warnings #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ogt_vox: split fatal errors and warnings #58

wants to merge 2 commits into from

Conversation

mgerhardy
Copy link
Collaborator

@mgerhardy mgerhardy commented Jul 31, 2023 •
edited
Loading

some ogt_asserts are no hard errors but only a warning. This PR should allow the user code to provide a ogt_warn functionality to prevent triggering an assert in such a scenario.

By default ogt_warn is set to ogt_assert.

Fixes issue #52

@mgerhardy mgerhardy changed the title Pr/ogt warn ogt_vox: split fatal errors and warnings Jul 31, 2023
@mgerhardy
Copy link
Collaborator Author

mgerhardy commented Jul 31, 2023 •
edited
Loading

I've left it as draft for now - because the locations of ogt_warn are open for discussion.

@mgerhardy mgerhardy mentioned this pull request Aug 1, 2023
Open
@mgerhardy mgerhardy requested a review from jpaver October 30, 2023 22:08
@mgerhardy mgerhardy marked this pull request as ready for review March 5, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpaver jpaver Awaiting requested review from jpaver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mgerhardy