-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace italic figure sample word #123
Comments
This is harder than it seems. I'm having trouble finding an open-source VF where a single font file contains upright and italic, and responds properly to the 'ital' axis being set. Separate files don't work as the browser doesn't download the italic one if it's not called. I've replaced it with Literata and separate files, but this is really not ideal as it's using syntax that only works with separate files. I'm going to have to rewrite the content a little bit to talk about separate vs combined VF files as they behave and are supported completely differently right now. |
(it is worth doing, but still a bummer. I should have thought this one through better) Also, will need a nice fancy Material toggle like on Optical Size (auto). Hoping that @kennethormandy can help with that. |
OK - I've updated the copy and added both demos to showcase the different strategies for combined or separate upright/italic VF files. Just needs toggles instead of the current widgets. |
Reassigning this one to @kennethormandy to add MD toggle component instead of radio buttons (same as on opsz component) |
Related to #123 and #124 - replace radio buttons with mdc-switch component. Currently the Sass isn’t compiling properly, which could be related to Ruby vs Dart Sass syntax differences. Found reference to similiar issue here: material-components/material-components-web#5631
Thanks Jason!
Are there any non-libre fonts that respond properly?
I'm not entirely sure what you mean... if they are separate files, then there is no
I wonder if there is a different way of explaining this that explains I also wonder if its worth discussing the other details in https://www.w3.org/TR/css-fonts-4/#font-style-prop, or just linking out to that page to learn more... I see https://www.w3.org/TR/css-fonts-3/#font-style-prop doesn't deal with VF at all, and (afaik) css-fonts-4 is not yet at the Recommendation stage... but I am fuzzy on the way CSS is evolving these days. |
I already rewrote the content to include talking about a single VF file with an ital axis or separate upright and ital, so that part's covered. But I think I may have found a hole in the implementation of how browsers are dealing with the separate files and custom properties. I'm not certain it's a bug, but it's definitely a problem. If you have both files included in your Anyway I think this section is in good shape short of having a Material 'switch' instead of a radio button. |
The italic figure sample word is
Good
but this doesn't have ana
org
in it, which the text explicitly mentions, so the sample word should be updatedThe text was updated successfully, but these errors were encountered: