Added test vectors from the IETF JOSE Cookbook for HMAC, RSA, and EC. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-adams
force-pushed
the
add-test-vectors
branch
from
adf721e to
7c870a8
Compare
|
I'm merging this even though it is failing so the test can verify the #158 fix. |
mark-adams
added a commit
that referenced
this pull request
May 19, 2015
Added test vectors from the IETF JOSE Cookbook for HMAC, RSA, and EC.
mark-adams
added a commit
to mark-adams/pyjwt
that referenced
this pull request
May 19, 2015
|
@mark-adams this was a great idea, thanks for getting it done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JOSE Cookbook has a very good set of test keys / signatures that we can use to verify our algorithms are functioning properly. Considering the recent discovery of our EC implementation being improper, I wanted to add these known good vectors to our test suite to verify everything is working properly prior to merging of #158.
It should be noted that there is a test in here for RSA-PSS that I'm not 100% I've written properly. I went ahead and left the test with a
@skipIfdecorator so that I can go in and fix it tomorrow once I know more about RSA-PSS.Once this is merged, the EC test should show up as failing and we can use that test to verify #158 has fixed the issue.