Refactor the parser to handle more use-cases #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a regex for line matching (based off of bkeepers/dotenv) * Substitute environment variables in a value * Handle unescaping of values * Add in lots of tests
|
@jamieconnolly this looks great for what I've been too look through. And it seems that it actually replaces #2 and #5, right? |
|
Yes, this supersedes both of those as well. |
jpadilla
added a commit
that referenced
this pull request
Dec 6, 2014
Refactor the parser to handle more use-cases
This was referenced Dec 6, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrying on the conversation started in #3, I've refactored the parser to handle more use-cases and better match default behaviour (based off of bkeepers/dotenv).
A summary of the changes: