Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugins, delete old rules and configure new rules #12

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Update plugins, delete old rules and configure new rules #12

merged 1 commit into from
Nov 15, 2021

Conversation

diogoazevedos
Copy link
Member

@diogoazevedos diogoazevedos commented Oct 12, 2021 •
edited
Loading

@diogoazevedos diogoazevedos added the upgrade Pull requests that update a dependency file label Oct 12, 2021
@diogoazevedos diogoazevedos requested a review from lo1tuma October 12, 2021 09:03
@diogoazevedos diogoazevedos force-pushed the chore/update-dependencies branch 2 times, most recently from 2e70c64 to a1cfa34 Compare November 9, 2021 15:41
@diogoazevedos diogoazevedos self-assigned this Nov 9, 2021
@diogoazevedos diogoazevedos force-pushed the chore/update-dependencies branch 2 times, most recently from 310923b to 84ac155 Compare November 9, 2021 15:53
@diogoazevedos diogoazevedos marked this pull request as ready for review November 9, 2021 15:54
@diogoazevedos diogoazevedos force-pushed the chore/update-dependencies branch from 84ac155 to e19358f Compare November 9, 2021 15:56
@diogoazevedos diogoazevedos requested review from screendriver and removed request for lo1tuma November 9, 2021 15:57
lo1tuma
lo1tuma approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diogoazevedos diogoazevedos merged commit b15316f into joyn:master Nov 15, 2021
@diogoazevedos diogoazevedos deleted the chore/update-dependencies branch November 15, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo1tuma lo1tuma lo1tuma approved these changes

@screendriver screendriver Awaiting requested review from screendriver

Assignees

@diogoazevedos diogoazevedos

Labels
upgrade Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogoazevedos @lo1tuma