This repository has been archived by the owner on May 4, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 653
Add the throw_safe variable to the uv_fs_s struct #1428
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is meant to control whether IO errors are created or not. This enables: nodejs/node-v0.x-archive#8189 The general idea is to throw less errors that are immediately caught.
Sorry, this is not the right place to add this. libuv is not Node, it's written in C and has no knowledge of what "throwing" is or who should use it. If you need extra fields just in Node you can define a struct as follows:
This way you can cast the |
He just added a variable without using it? |
@txdv yes, it's supposed to be used by Node, check the link provided in the original message. That's why it has no place in libuv. |
errendir
pushed a commit
to errendir/node
that referenced
this pull request
Aug 19, 2014
Thanks saghul: joyent/libuv#1428
errendir
pushed a commit
to errendir/node
that referenced
this pull request
Aug 19, 2014
Thanks saghul: joyent/libuv#1428
errendir
added a commit
to errendir/node
that referenced
this pull request
Aug 19, 2014
Thanks saghul: joyent/libuv#1428
errendir
added a commit
to errendir/node
that referenced
this pull request
Aug 19, 2014
In some environment (especially when coffescript is involved) module.js will spend a lot of time looking up nonexisting files. This is caused by the lengthy error creation. Those errors are then immediately caught. This change makes the lookup much faster, by avoiding the unnecessary error creation. module::statPath now uses the new second parameter of fs.statSync function of the fs.js. There is a similar change for the fs.stat, adding the third parameter. Apply suggestions from libuv pull request Thanks saghul: joyent/libuv#1428 Fix the datastructures for async
errendir
added a commit
to errendir/node
that referenced
this pull request
Aug 20, 2014
In some environment (especially when coffescript is involved) module.js will spend a lot of time looking up nonexisting files. This is caused by the lengthy error creation. Those errors are then immediately caught. This change makes the lookup much faster, by avoiding the unnecessary error creation. module::statPath now uses the new second parameter of fs.statSync function of the fs.js. There is a similar change for the fs.stat, adding the third parameter. Apply suggestions from libuv pull request Thanks saghul: joyent/libuv#1428 Fix the datastructures for async
errendir
added a commit
to errendir/node
that referenced
this pull request
Sep 3, 2014
In some environment (especially when coffescript is involved) module.js will spend a lot of time looking up nonexisting files. This is caused by the lengthy error creation. Those errors are then immediately caught. This change makes the lookup much faster, by avoiding the unnecessary error creation. module::statPath now uses the new second parameter of fs.statSync function of the fs.js. There is a similar change for the fs.stat, adding the third parameter. Apply suggestions from libuv pull request Thanks saghul: joyent/libuv#1428 Fix the datastructures for async Conflicts: lib/module.js src/node_file.cc src/node_file.h
errendir
added a commit
to errendir/node
that referenced
this pull request
Sep 3, 2014
In some environment (especially when coffescript is involved) module.js will spend a lot of time looking up nonexisting files. This is caused by the lengthy error creation. Those errors are then immediately caught. This change makes the lookup much faster, by avoiding the unnecessary error creation. module::statPath now uses the new second parameter of fs.statSync function of the fs.js. There is a similar change for the fs.stat, adding the third parameter. Apply suggestions from libuv pull request Thanks saghul: joyent/libuv#1428 Fix the datastructures for async Conflicts: lib/module.js src/node_file.cc src/node_file.h
errendir
added a commit
to errendir/node
that referenced
this pull request
Sep 3, 2014
In some environment (especially when coffescript is involved) module.js will spend a lot of time looking up nonexisting files. This is caused by the lengthy error creation. Those errors are then immediately caught. This change makes the lookup much faster, by avoiding the unnecessary error creation. module::statPath now uses the new second parameter of fs.statSync function of the fs.js. There is a similar change for the fs.stat, adding the third parameter. Apply suggestions from libuv pull request Thanks saghul: joyent/libuv#1428 Fix the datastructures for async Documentation update Add tests and simplify Stat function Apply the code review comments
errendir
added a commit
to errendir/node
that referenced
this pull request
Sep 3, 2014
In some environment (especially when coffescript is involved) module.js will spend a lot of time looking up nonexisting files. This is caused by the lengthy error creation. Those errors are then immediately caught. This change makes the lookup much faster, by avoiding the unnecessary error creation. module::statPath now uses the new second parameter of fs.statSync function of the fs.js. There is a similar change for the fs.stat, adding the third parameter. Apply suggestions from libuv pull request Thanks saghul: joyent/libuv#1428 Fix the datastructures for async Documentation update Add tests and simplify Stat function Apply the code review comments
errendir
added a commit
to errendir/node
that referenced
this pull request
Sep 3, 2014
In some environment (especially when coffescript is involved) module.js will spend a lot of time looking up nonexisting files. This is caused by the lengthy error creation. Those errors are then immediately caught. This change makes the lookup much faster, by avoiding the unnecessary error creation. module::statPath now uses the new second parameter of fs.statSync function of the fs.js. There is a similar change for the fs.stat, adding the third parameter. Apply suggestions from libuv pull request Thanks saghul: joyent/libuv#1428 Fix the datastructures for async Documentation update Add tests and simplify Stat function Apply the code review comments
errendir
added a commit
to errendir/node
that referenced
this pull request
Sep 8, 2014
In some environment (especially when coffescript is involved) module.js will spend a lot of time looking up nonexisting files. This is caused by the lengthy error creation. Those errors are then immediately caught. This change makes the lookup much faster, by avoiding the unnecessary error creation. module::statPath now uses the new second parameter of fs.statSync function of the fs.js. There is a similar change for the fs.stat, adding the third parameter. Apply suggestions from libuv pull request Thanks saghul: joyent/libuv#1428 Fix the datastructures for async Documentation update Add tests and simplify Stat function Apply the code review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable is meant to control whether IO errors are created or not.
This enables: nodejs/node-v0.x-archive#8189
The general idea is to throw less errors that are immediately caught.
This throw and catch behaviour is present in the module.js and can
significantly slow down the require calls (especially in case of coffeescript).