-
Notifications
You must be signed in to change notification settings - Fork 653
Support android cross compile on mac. #1214
Conversation
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit eddyb/libuv@fc1f4de has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
HAve you tried using these instructions? https://github.com/joyent/libuv#android |
I tried using those instructions, but they didn't quite work out for me. I ran into numerous problems running the script, but when I got it configured I get make errors such as https://gist.github.com/alexcrichton/9858498. I'm not entirely sure why gcc isn't being invoked correctly, but it looks like it's attempting to build with |
Do you have these binaries in your toolchain? https://github.com/joyent/libuv/blob/master/android-configure#L11-L14 I'll give it a try myself, but it'll take me a bit... |
I do indeed, I think that gyp may just be passing through the wrong flags, or expecting ARM on OSX to be for iOS rather than android? |
yeah, it's work for me |
nvmind, I see attached patch helps me proceed, thanks. |
@abhinavsingh the attached patch is a bit of a hack. We need a better way to this, alas I couldn't find the time to dig into it. If you have any idea on how to do it properly, that would be great :-) |
I think this can be closed as no longer relevant now that rust has dropped libuv? Or is it applicable outside of cross-compiling rust? |
Ben, I encountered this when I was compiling C code (depending upon libuv) On Wed Oct 01 2014 at 4:26:08 PM Ben Noordhuis [email protected]
|
Closing old PRs of mine. |
Upstreaming @yichoi's patch from @rust-lang libuv.