Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

Support android cross compile on mac. #1214

Closed
wants to merge 1 commit into from

Conversation

eddyb
Copy link

@eddyb eddyb commented Mar 25, 2014

Upstreaming @yichoi's patch from @rust-lang libuv.

@Nodejs-Jenkins
Copy link

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit eddyb/libuv@fc1f4de has the following error(s):

  • Commit message must indicate the subsystem this commit changes

The following commiters were not found in the CLA:

  • Young-il Choi

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@saghul
Copy link
Contributor

saghul commented Mar 29, 2014

HAve you tried using these instructions? https://github.com/joyent/libuv#android

@alexcrichton
Copy link

I tried using those instructions, but they didn't quite work out for me. I ran into numerous problems running the script, but when I got it configured I get make errors such as https://gist.github.com/alexcrichton/9858498.

I'm not entirely sure why gcc isn't being invoked correctly, but it looks like it's attempting to build with -arch x86_64 even though the target_arch to gyp is arm. I don't really fully understand gyp though, so I may be doing something wrong!

@saghul
Copy link
Contributor

saghul commented Apr 3, 2014

Do you have these binaries in your toolchain? https://github.com/joyent/libuv/blob/master/android-configure#L11-L14

I'll give it a try myself, but it'll take me a bit...

@alexcrichton
Copy link

I do indeed, I think that gyp may just be passing through the wrong flags, or expecting ARM on OSX to be for iOS rather than android?

@saghul
Copy link
Contributor

saghul commented Apr 4, 2014

@xudejian
Copy link

xudejian commented Jul 7, 2014

yeah, it's work for me

@abhinavsingh
Copy link

nvmind, I see attached patch helps me proceed, thanks.

@saghul
Copy link
Contributor

saghul commented Jul 28, 2014

@abhinavsingh the attached patch is a bit of a hack. We need a better way to this, alas I couldn't find the time to dig into it. If you have any idea on how to do it properly, that would be great :-)

@bnoordhuis
Copy link
Contributor

I think this can be closed as no longer relevant now that rust has dropped libuv? Or is it applicable outside of cross-compiling rust?

@abhinavsingh
Copy link

Ben, I encountered this when I was compiling C code (depending upon libuv)
using NDK build system for Android.

On Wed Oct 01 2014 at 4:26:08 PM Ben Noordhuis [email protected]
wrote:

I think this can be closed as no longer relevant now that rust has dropped
libuv? Or is it applicable outside of cross-compiling rust?


Reply to this email directly or view it on GitHub
#1214 (comment).

@eddyb
Copy link
Author

eddyb commented May 12, 2017

Closing old PRs of mine.

@eddyb eddyb closed this May 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants