This repository has been archived by the owner on May 4, 2018. It is now read-only.
windows: Always initialize the uv_process_t #1117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit alexcrichton/libuv@cf9fbc3 has the following error(s):
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
The unix implementation of uv_spawn always starts out with a uv__handle_init, but the windows implementation sometimes bails out early before calling uv__handle_init. This means that uv_close on a failed uv_spawn will always succeed on unix but sometimes fail on windows. This commit lifts the initialization of the uv_process_t above all of the error checking to ensure that uv_close will always work when uv_spawn returns an error.
|
Thanks! Landed in 6f62d62. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unix implementation of uv_spawn always starts out with a
uv__handle_init, but the windows implementation sometimes bails out early
before calling uv__handle_init. This means that uv_close on a failed
uv_spawn will always succeed on unix but sometimes fail on windows.
This commit lifts the initialization of the uv_process_t above all of the
error checking to ensure that uv_close will always work when uv_spawn
returns an error.