Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

hardware_products + json_schemas #1084

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

karenetheridge
Copy link
Contributor

Add database and api endpoint support for associating json_schemas with hardware_products

new endpoints:

  • POST /hardware_product/:hardware_product_id_or_other/json_schema/:json_schema_id
  • POST /hardware_product/:hardware_product_id_or_other/json_schema/:json_schema_type/:json_schema_name/:json_schema_version
  • GET /hardware_product/:hardware_product_id_or_other/json_schema
  • DELETE /hardware_product/:hardware_product_id_or_other/json_schema/:json_schema_id
  • DELETE /hardware_product/:hardware_product_id_or_other/json_schema/:json_schema_type/:json_schema_name/:json_schema_version
  • DELETE /hardware_product/:hardware_product_id_or_other/json_schema

Also add ?with_hardware_products=1 option to GET /json_schema/:type/... endpoints
for listing the hardware_products that make use of that JSON Schema.

@karenetheridge karenetheridge added enhancement extends current functionality api needs-shell needs accompanying changes in conch-shell needs-ui needs accompanying changes in conch-ui database involves database schema or config changes, or non-trivial query authoring v3.next features, big changes for api v3.<next> labels Jan 8, 2021
@karenetheridge karenetheridge added this to the v3.2.1 milestone Jan 8, 2021
dustinryerson
dustinryerson previously approved these changes Jan 13, 2021
perigrin
perigrin previously approved these changes Jan 13, 2021
POST /hardware_product/:hardware_product_id_or_other/json_schema/:json_schema_id
POST /hardware_product/:hardware_product_id_or_other/json_schema/:json_schema_type/:json_schema_name/:json_schema_version
GET /hardware_product/:hardware_product_id_or_other/json_schema
DELETE /hardware_product/:hardware_product_id_or_other/json_schema/:json_schema_id
DELETE /hardware_product/:hardware_product_id_or_other/json_schema/:json_schema_type/:json_schema_name/:json_schema_version
DELETE /hardware_product/:hardware_product_id_or_other/json_schema

also add ?with_hardware_products=1 option to GET /json_schema/:type/... endpoints
for listing the hardware_products that make use of that JSON Schema.
@karenetheridge karenetheridge dismissed stale reviews from perigrin and dustinryerson via 2a782a7 January 14, 2021 18:26
@karenetheridge karenetheridge force-pushed the ether/v3.2-hardware_product_json_schemas branch from 7f46bf0 to 2a782a7 Compare January 14, 2021 18:26
@karenetheridge karenetheridge merged commit 114be7c into master Jan 14, 2021
@karenetheridge karenetheridge deleted the ether/v3.2-hardware_product_json_schemas branch January 14, 2021 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api database involves database schema or config changes, or non-trivial query authoring enhancement extends current functionality needs-shell needs accompanying changes in conch-shell needs-ui needs accompanying changes in conch-ui v3.next features, big changes for api v3.<next>
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants