Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow efficient diffing from the command line (integrated with idahunt) #246

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

saidelike
Copy link

An example of use for this is in idahunt. See detailed example in https://github.com/nccgroup/idahunt#binary-diffing where it shows how IDA is called and what environment variables are set. We obtain https://github.com/nccgroup/idahunt/blob/main/img/TmRecoverResourceManagerExt.png

The code changes consists in:

  • distinguishing the code generation (assembly and pseudo code) from showing it in IDA, so we can generate the code from the command line without showing it
  • support more DIAPHORA_AUTO + other environment variables to call it from the command line

diaphora_ida.py Outdated Show resolved Hide resolved
Copy link
Owner

@joxeankoret joxeankoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your patches! I have written a review for this PR. I hope it finds you well, my aim is not to annoy or bother you.

diaphora_ida.py Outdated Show resolved Hide resolved
diaphora.py Outdated Show resolved Hide resolved
diaphora_ida.py Show resolved Hide resolved
diaphora.py Show resolved Hide resolved
diaphora_ida.py Outdated Show resolved Hide resolved
@saidelike
Copy link
Author

I've made additional changes and commented on your comments. Thanks for the feedbacks.

@saidelike
Copy link
Author

I've made the additional changes based on your feedbacks. If you are happy with them, feel free to merge.

@joxeankoret joxeankoret merged commit ef10cca into joxeankoret:master Dec 15, 2022
@joxeankoret
Copy link
Owner

And changes integrated. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants