Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular permissions for websites #103

Open
Kixunil opened this issue Dec 19, 2018 · 0 comments
Open

Granular permissions for websites #103

Kixunil opened this issue Dec 19, 2018 · 0 comments
Labels
enhancement New feature or request security

Comments

@Kixunil
Copy link

Kixunil commented Dec 19, 2018

Description of the Feature or Idea

Currently, when you try to use Joule with Lightning Spin, it looks like it provides lightning spin more private information (node ID etc) than it actually does.

I suggest that instead of showing window on enable() call, enable it by default, but disable all potentially dangerous features (getinfo). Only ask user if the site actually attempts to use such more dangerous feature. This has added benefit that users are not bothered with permissions window when using a site that doesn't require getinfo.

Existing Example(s) of Feature

I think this can be compared to newer versions of Android, which ask when an application actually wants to use camera instead of asking it beforehand. I'm not sure of any other similar case, but I guess there are some. I find it definitely a useful approach.

This issue is based on discussion in joule-labs/webln#9

@wbobeirne wbobeirne added enhancement New feature or request security labels Dec 26, 2018
wbobeirne pushed a commit that referenced this issue Oct 13, 2020
…n/@babel/plugin-transform-react-constant-elements-7.10.4

Update @babel/plugin-transform-react-constant-elements: 7.10.1 → 7.10.4 (patch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

No branches or pull requests

2 participants