Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on IE10 #194

Merged
merged 1 commit into from
Oct 14, 2017
Merged

Fix on IE10 #194

merged 1 commit into from
Oct 14, 2017

Conversation

nicolasraynaud-millevolts
Copy link
Contributor

The props property doesn't seem to be initialized at this point when creating a component, which leads to an error.

The `props` property doesn't seem to be initialized at this point when creating a <FlipMove> component, which leads to an error.
@joshwcomeau
Copy link
Owner

Huh, interesting. Seems odd to be that a variable's instantiation would be browser-specific o_O.

That said, I don't really see any downside to this fix, so if it works... ¯_(ツ)_/¯

I have a couple style nits, but I can just do them as a followup commit. I'll share the commit here, so that if you're interested in contributing again, you'll know a bit more about our conventions.

@joshwcomeau joshwcomeau merged commit 49ca54f into joshwcomeau:master Oct 14, 2017
@nicolasraynaud-millevolts
Copy link
Contributor Author

Thanks! Right after my PR I've seen that you set lint and styling in the pre-push hook, I'll PR correctly next time ;)

joshwcomeau added a commit that referenced this pull request Oct 15, 2017
@joshwcomeau
Copy link
Owner

Yeah, actually I'm surprised the hook didn't take care of the lint issue!

The change was small, just added a comment and fixed the ternary styling.

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants