- remove console and debugger statements

- remove user menu - add changelog Signed-off-by: Josh Romero <[email protected]>
joshuarrrr · Jan 5, 2024 · 1782c6a · 1782c6a
1 parent f49765d
commit 1782c6a
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 532 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - [Discover] Display inner properties in the left navigation bar [#5429](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5429)
 - [Chrome] Introduce registerCollapsibleNavHeader to allow plugins to customize the rendering of nav menu header ([#5244](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5244))
 - [Custom Branding] Relative URL should be allowed for logos ([#5572](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5572))
+- [Theme] Make theme and dark mode settings device specific (in local storage) ([#5652](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5652))
 
 ### 🐛 Bug Fixes
 
@@ -953,4 +954,4 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ### 🔩 Tests
 
-- Update caniuse to fix failed integration tests ([#2322](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2322))
+- Update caniuse to fix failed integration tests ([#2322](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2322))
diff --git a/src/legacy/ui/ui_render/startup/template.js.hbs b/src/legacy/ui/ui_render/startup/template.js.hbs
@@ -12,8 +12,6 @@ var browserThemeVersion = uiSettings['theme:version'] || {};
 
 var rawDarkMode = typeof browserDarkMode.userValue !== 'boolean' ? {{configDarkMode}} : browserDarkMode.userValue
 
-debugger;
-
 var rawThemeVersion = browserThemeVersion.userValue || '{{configThemeVersion}}'
 
 // TODO: should this reflect config defaults instead?

diff --git a/src/plugins/advanced_settings/public/account-app.tsx b/src/plugins/advanced_settings/public/account-app.tsx
@@ -7,32 +7,10 @@ import React from 'react';
 import ReactDOM from 'react-dom';
 import { CoreStart } from 'opensearch-dashboards/public';
 import { OpenSearchDashboardsContextProvider } from '../../opensearch_dashboards_react/public';
-import { HeaderUserMenu } from './header_user_menu';
 import { HeaderUserThemeMenu } from './header_user_theme_menu';
 
-export async function setupTopNavUserButton(coreStart: CoreStart) {
-  coreStart.chrome.navControls.registerRight({
-    // Pin to rightmost, since newsfeed plugin is using 1000, here needs a number > 1000
-    order: 2000,
-    mount: (element: HTMLElement) => {
-      ReactDOM.render(
-        <OpenSearchDashboardsContextProvider
-          services={{
-            ...coreStart,
-          }}
-        >
-          <HeaderUserMenu />
-        </OpenSearchDashboardsContextProvider>,
-        element
-      );
-      return () => ReactDOM.unmountComponentAtNode(element);
-    },
-  });
-}
-
 export async function setupTopNavThemeButton(coreStart: CoreStart) {
   coreStart.chrome.navControls.registerRight({
-    // Pin to rightmost, since newsfeed plugin is using 1000, here needs a number > 1000
     order: 2001,
     mount: (element: HTMLElement) => {
       ReactDOM.render(