[Metrics UI] Fix Inventory View sorting by handling null values (elas…

…tic#67889) (elastic#68838) * [Metrics UI] Fix Inventory View sorting by handling null values * Fixing situation where the id is not unique Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
joshdover · Jun 15, 2020 · 264c4f2 · 264c4f2
1 parent b17b2c3
commit 264c4f2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ck/plugins/infra/public/pages/metrics/inventory_view/components/waffle/group_of_nodes.tsx b/...ck/plugins/infra/public/pages/metrics/inventory_view/components/waffle/group_of_nodes.tsx
@@ -44,7 +44,7 @@ export const GroupOfNodes: React.FC<Props> = ({
       <Nodes>
         {group.nodes.map((node) => (
           <Node
-            key={node.pathId}
+            key={`${node.pathId}:${node.name}`}
             options={options}
             squareSize={group.squareSize}
             node={node}

diff --git a/x-pack/plugins/infra/public/pages/metrics/inventory_view/lib/sort_nodes.ts b/x-pack/plugins/infra/public/pages/metrics/inventory_view/lib/sort_nodes.ts
@@ -10,7 +10,7 @@ import { WaffleSortOption } from '../hooks/use_waffle_options';
 
 const SORT_PATHS = {
   name: (node: SnapshotNode) => last(node.path),
-  value: 'metric.value',
+  value: (node: SnapshotNode) => node.metric.value || 0,
 };
 
 export const sortNodes = (sort: WaffleSortOption, nodes: SnapshotNode[]) => {