Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

body-leading-blank fires erroneously when commit has leading comment and newline #108

Closed
joshbolduc opened this issue May 6, 2021 · 0 comments
Closed

body-leading-blank fires erroneously when commit has leading comment and newline #108

joshbolduc opened this issue May 6, 2021 · 0 comments
Assignees
@joshbolduc
Labels
bug Something isn't working

Comments

@joshbolduc
Copy link
Owner

When body-leading-blank is enabled, it fires incorrectly for this content:

# Comment

Header

Body line

This can be triggred, for example, when squashing multiple commits together during a rebase.
@joshbolduc joshbolduc added the bug Something isn't working label May 6, 2021
@joshbolduc joshbolduc self-assigned this May 7, 2021
joshbolduc added a commit that referenced this issue May 7, 2021
@joshbolduc
fix: trim leading newlines before parsing
32eeb8b 
Ensure that leading (and trailing) newlines are trimmed from a commit
before parsing it, after accounting for commented lines.

Fixes #108
joshbolduc added a commit that referenced this issue May 7, 2021
@joshbolduc
fix: trim leading newlines before parsing
f93f6d3 
Ensure that leading (and trailing) newlines are trimmed from a commit
before parsing it, after accounting for commented lines.

Fixes #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshbolduc joshbolduc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshbolduc