Improve feedback when ALPR/platerecognizer gives no results #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the Slack thread at https://reportedcab.slack.com/archives/C9VNM3DL4/p1664032483942889?thread_ts=1657582859.783929&cid=C9VNM3DL4: > yeah... it looks like this one did get resized to within the > platerecognizer API file size limit (though, interestingly, the initial > run of the sharp library actually increased the size), here's > the server-side logs when I run the webapp locally. > > ``` > image buffer length BEFORE sharp: 2185751 bytes > image buffer length AFTER sharp: 2649569 bytes > orientImageBuffer: 741.517ms > file size is greater than maximum of 2411654 bytes, attempting to scale down to width of 4096 > file size after scaling down: 2054754 bytes > ``` > > and the platerecognizer API responded with no results, indicating that > it was able to process the image, it just couldn't find a plate > 😕here's the API response that went to the browser: > > ```json > { > "processing_time": 128.126, > "results": [], > "filename": "1510_1xG41_e12aa9e8-4915-4219-bcbb-5f11417c81f2.jpg", > "version": 1, > "camera_id": null, > "timestamp": "2022-09-24T15:10:28.270005Z" > } > ``` > > Maybe a good next step would be to make the error messaging > differentiate between the following two cases: > > * there was an error processing the image, such as it being too large for the API > * the API processed the image, but didn't find any plates > > This would make it easier to understand what's going on, without me > having to try the image myself and look at the logs to figure it out
josephfrazier
commented
Oct 16, 2022
src/routes/home/Home.js
Outdated
Comment on lines
655
to
660
| if (err == 'license plate (image was read, but no plates were found)') { | ||
| throw err; | ||
| } | ||
| console.error(err.stack); | ||
|
|
||
| throw 'license plate'; // eslint-disable-line no-throw-literal | ||
| throw 'license plate (image could not be read)'; // eslint-disable-line no-throw-literal |
There was a problem hiding this comment.
I'm not sure if using parenthetical text is the best way to convey what happened, especially if GPS and/or timestamp also could not be read. For one, users may not read all the text, so it may not be clear what happened with the plate-reading.
josephfrazier
commented
Oct 16, 2022
src/routes/home/Home.js
Outdated
| @@ -648,9 +652,12 @@ class Home extends React.Component { | |||
| this.attachmentPlates.set(attachmentFile, result); | |||
| return result; | |||
| } catch (err) { | |||
| if (err == 'license plate (image was read, but no plates were found)') { | |||
There was a problem hiding this comment.
Instead of copy/pasting this exact error message, we should probably make a constant for it.
|
I'm starting to think this code could first use some cleanup and automated tests, so I can feel more confident about changing it without needing to manually test things as much. Since #252 also affects error-handling, maybe it'd be good to think about both this change and that one, when considering how to refactor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Slack thread at https://reportedcab.slack.com/archives/C9VNM3DL4/p1664032483942889?thread_ts=1657582859.783929&cid=C9VNM3DL4: