Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip SSL verification when checking if the source file exists #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hlaf
Copy link
Contributor

@hlaf hlaf commented Jun 11, 2023

Enables the use of an ovf_source with a self-signed certificate and ensures consistency with the use of ovftool's '--noSSLVerify' option.

Enables the use of an ovf_source with a self-signed certificate and
ensures consistency with the use of ovftool's '--noSSLVerify' option.
@hlaf hlaf changed the title Skip SSL verification when checking if the source file exists. Skip SSL verification when checking if the source file exists Jun 11, 2023
@josenk
Copy link
Owner

josenk commented Jul 18, 2023

Not secure to set this. I think it would be better if you use real certs on your ovf_source urls. Let's Encrypt is a possible solution.

@hlaf
Copy link
Contributor Author

hlaf commented Jul 18, 2023

I agree that this is not secure. I was misled by the use of the --noSSLVerify ovftool command-line option to build ovf_cmd, which seemed to suggest that SSL verification was to be skipped both for the destination and source connections. It seems that more recent versions of ovftool now have --noSourceSSLVerify and --noDestinationSSLVerify options to support use cases such as this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants