fix(storage): use securerandom to generate aliases

joseivanlopez · Dec 20, 2024 · b12898a · b12898a
1 parent a108175
commit b12898a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/service/lib/agama/storage/configs/with_alias.rb b/service/lib/agama/storage/configs/with_alias.rb
@@ -19,6 +19,8 @@
 # To contact SUSE LLC about this file by physical or electronic mail, you may
 # find current contact information at www.suse.com.
 
+require "securerandom"
+
 module Agama
   module Storage
     module Configs
@@ -36,7 +38,7 @@ def alias?(value)
 
         # Ensures the config has a value for alias.
         def ensure_alias
-          self.alias ||= "device#{rand(10**9)}"
+          self.alias ||= SecureRandom.alphanumeric(10)
         end
       end
     end

diff --git a/service/test/agama/storage/config_solver_test.rb b/service/test/agama/storage/config_solver_test.rb
@@ -149,7 +149,7 @@
           it "sets an alias to the root drive" do
             subject.solve(config)
             drive = config.drives.first
-            expect(drive.alias).to match(/device\d*/)
+            expect(drive.alias).to_not be_nil
           end
 
           it "sets the alias of root drive as boot device alias" do
@@ -200,7 +200,7 @@
               it "sets an alias to the drive" do
                 subject.solve(config)
                 drive = config.drives.find { |d| d.search.name == "/dev/vda" }
-                expect(drive.alias).to match(/device\d*/)
+                expect(drive.alias).to_not be_nil
               end
 
               it "sets the alias of the drive as boot device alias" do