Update to use MGC #305
Open
Update to use MGC #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.dotnet/OpenAI.Microsoft.Generator.CSharp.ClientModel.Plugin/OpenAILibraryVisitor.cs
Outdated
Show resolved
Hide resolved
.dotnet/OpenAI.Microsoft.Generator.CSharp.ClientModel.Plugin/OpenAILibraryVisitor.cs
Outdated
Show resolved
Hide resolved
.dotnet/OpenAI.Microsoft.Generator.CSharp.ClientModel.Plugin/OpenAILibraryVisitor.cs
Outdated
Show resolved
Hide resolved
.dotnet/OpenAI.Microsoft.Generator.CSharp.ClientModel.Plugin/OpenAILibraryVisitor.cs
Outdated
Show resolved
Hide resolved
.dotnet/OpenAI.Microsoft.Generator.CSharp.ClientModel.Plugin/OpenAILibraryVisitor.cs
Outdated
Show resolved
Hide resolved
.dotnet/OpenAI.Microsoft.Generator.CSharp.ClientModel.Plugin/OpenAILibraryVisitor.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
commented
Nov 7, 2024
JoshLove-msft
commented
Nov 7, 2024
| @@ -2869,7 +3603,7 @@ public class RealtimeConversationClient { | |||
| protected internal RealtimeConversationClient(ClientPipeline pipeline, OpenAIClientOptions options); | |||
| public RealtimeConversationClient(string model, ApiKeyCredential credential, OpenAIClientOptions options); | |||
| public RealtimeConversationClient(string model, ApiKeyCredential credential); | |||
| public virtual ClientPipeline Pipeline { get; } | |||
| public ClientPipeline Pipeline { get; } | |||
There was a problem hiding this comment.
Has this already shipped? I think we don't want the virtual keyword for Pipeline properties.
JoshLove-msft
commented
Nov 7, 2024
JoshLove-msft
commented
Nov 7, 2024
| /// <summary> | ||
| /// The HTTP pipeline for sending and receiving REST requests and responses. | ||
| /// </summary> | ||
| public ClientPipeline Pipeline => _pipeline; |
There was a problem hiding this comment.
These customizations are no longer needed as MGC generates the property as non-virtual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches over the generator from autorest.csharp to the new Microsoft.Generator.CSharp.