Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CakePHP 5 upgrade #50

Merged
merged 13 commits into from
Jan 9, 2024
Merged

CakePHP 5 upgrade #50

merged 13 commits into from
Jan 9, 2024

Conversation

robertpustulka
Copy link
Contributor

An attempt to make this plugin compatible with CakePHP 5

@robertpustulka
Copy link
Contributor Author

@josegonzalez Could you take a look?

@robertpustulka
Copy link
Contributor Author

Or @jeremyharris maybe? :)

@jeremyharris
Copy link
Collaborator

@robertpustulka I haven't used library this in a very long time; none of the current cake projects I'm working with are even upgraded to 5 :/ I don't really qualify as a maintainer anymore, but I'll try.

It looks like travis isn't relevant to the project anymore so we should probably use GH actions for CI so we can see that everything is working ok. When I can see the matrix of tests passing I'll be pretty confident to merge this.

Anyway sorry for the delay. I'll be able to look at this and work on GH actions early next week though :)

@jeremyharris
Copy link
Collaborator

Hey @robertpustulka I went ahead and added a GH CI workflow and all the tests pass on the versions you specified in the travis yml so I'm merging this and I'll tag a release so you can get back to using the lib :) Thanks for all the work!

@jeremyharris jeremyharris merged commit cc775bc into josegonzalez:master Jan 9, 2024
@robertpustulka
Copy link
Contributor Author

Thanks a lot!

@josegonzalez
Copy link
Owner

Happy to donate/move this project to friendsofcake if there is significant usage/someone there wants to take over ownership :)

@robertpustulka robertpustulka deleted the cake5 branch March 7, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants