-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CakePHP 5 upgrade #50
Conversation
@josegonzalez Could you take a look? |
Or @jeremyharris maybe? :) |
@robertpustulka I haven't used library this in a very long time; none of the current cake projects I'm working with are even upgraded to 5 :/ I don't really qualify as a maintainer anymore, but I'll try. It looks like travis isn't relevant to the project anymore so we should probably use GH actions for CI so we can see that everything is working ok. When I can see the matrix of tests passing I'll be pretty confident to merge this. Anyway sorry for the delay. I'll be able to look at this and work on GH actions early next week though :) |
Hey @robertpustulka I went ahead and added a GH CI workflow and all the tests pass on the versions you specified in the travis yml so I'm merging this and I'll tag a release so you can get back to using the lib :) Thanks for all the work! |
Thanks a lot! |
Happy to donate/move this project to friendsofcake if there is significant usage/someone there wants to take over ownership :) |
An attempt to make this plugin compatible with CakePHP 5