[RFC] Added typing support #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will leave maintainer to review, but quick drive-by comment: In order to get those Postgres builds to pass, you'll need to run them against version 9.4 or above for to |
|
Thanks @chris48s, I added it to the travis yaml. If José wants, we can remove that change and I can add a skip to the test case if it's in the postgresql build. |
josegonzalez
requested changes
May 25, 2018
| * @param string $direction Direction (toPHP or toDatabase) | ||
| * @return array | ||
| */ | ||
| protected function _convertFieldsToType(array $fields, $direction) |
There was a problem hiding this comment.
Can we get a test for this?
There was a problem hiding this comment.
It is implicitly tested in the new tests, except for the invalid argument exception which I can add a test for.
|
ping |
josegonzalez
approved these changes
Jul 9, 2018
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type support to versions. You can now save versions that have fields with non scalar types, and all version entities now respect the field's type.