Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional data coming from right table. #27

Merged
merged 3 commits into from
Mar 26, 2017
Merged

Fix additional data coming from right table. #27

merged 3 commits into from
Mar 26, 2017

Conversation

dereuromark
Copy link
Contributor

We must read the created/user_id from the correct table, in this case the versions one.

Now a versions dropdown can actually display the additional meta data:

<option value="6">6 (3/19/17, 9:30 PM by uid 2)</option>

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 91.954% when pulling d1022ad on dereuromark:master-bugfix into 3c69b8e on josegonzalez:master.

@josegonzalez
Copy link
Owner

Tests?

@dereuromark
Copy link
Contributor Author

There are some, they just didnt check the exact datetime value.
Feel free to post add a few more.

PS: Is there a version release planned? Thx

@josegonzalez
Copy link
Owner

I'll merge/release when you add a test proving that the previous functionality didn't work.

@dereuromark
Copy link
Contributor Author

Yeah, in order to prevent regression it is safer to add a test case.
I also asserted on the value itself.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 91.954% when pulling 5b95c0e on dereuromark:master-bugfix into 3c69b8e on josegonzalez:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 91.954% when pulling 5b95c0e on dereuromark:master-bugfix into 3c69b8e on josegonzalez:master.

@josegonzalez josegonzalez merged commit b757edc into josegonzalez:master Mar 26, 2017
@josegonzalez
Copy link
Owner

Released.

@dereuromark dereuromark deleted the master-bugfix branch March 27, 2017 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants