Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return value in VersionTrait::versions() #23

Merged
merged 1 commit into from
Mar 19, 2017
Merged

Fix return value in VersionTrait::versions() #23

merged 1 commit into from
Mar 19, 2017

Conversation

dereuromark
Copy link
Contributor

Small regression, we should also add a few more tests probably for the trait.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.667% when pulling 669bb09 on dereuromark:master into c5fef09 on josegonzalez:master.

@josegonzalez josegonzalez merged commit f4b0188 into josegonzalez:master Mar 19, 2017
@josegonzalez
Copy link
Owner

@dereuromark can you also update the test fails so I can make a release?

@josegonzalez josegonzalez changed the title Fix return value. Fix return value in VersionTrait::versions() Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereuromark @coveralls @josegonzalez