E_USER_WARNING error when png/blur enabled without required functions… #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… available generate error logs when blur is enabled but the required function imagefilter is not available. likewise if imageFormat="png" but imagepng is not available. in development environments, this should catch the developer's attention immediately (display_errors=1 and broken images), whilst on production servers, should at generate some error logs so sysadmins can notice :p IMO, it's even debatable whether or not image generation should continue, with reduced security, if blur is enabled but imagefilter is not, or if we should just outright cast an exception, because... reduced security! / presumably easier captcha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… available
generate error logs when blur is enabled but the required function imagefilter is not available.
likewise if imageFormat="png" but imagepng is not available.
in development environments, this should catch the developer's attention immediately (display_errors=1 and broken images), whilst on production servers, should at generate some error logs so sysadmins can notice :p
IMO, it's even debatable whether or not image generation should continue, with reduced security, if blur is enabled but imagefilter is not, or if we should just outright cast an exception, because... reduced security! / presumably easier captcha