Skip to content

Commit

Permalink
chore: refactor updateProps to update every property one by one, an…
Browse files Browse the repository at this point in the history 
…d support `undefined`
  • Loading branch information
@josdejong
josdejong committed Oct 22, 2024
1 parent 6f0422d commit 3a2664c
Showing 1 changed file with 166 additions and 36 deletions.
202 changes: 166 additions & 36 deletions src/lib/components/JSONEditor.svelte
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,45 +59,73 @@
// TODO: document how to enable debugging in the readme: localStorage.debug="jsoneditor:*", then reload
const debug = createDebug('jsoneditor:JSONEditor')
export let content: Content = { text: '' }
export let selection: JSONEditorSelection | undefined = undefined
export let readOnly = false
export let indentation: number | string = 2
export let tabSize = 4
export let mode: Mode = Mode.tree
export let mainMenuBar = true
export let navigationBar = true
export let statusBar = true
export let askToFormat = true
export let escapeControlCharacters = false
export let escapeUnicodeCharacters = false
export let flattenColumns = true
export let parser: JSONParser = JSON
export let validator: Validator | undefined = undefined
export let validationParser: JSONParser = JSON
export let pathParser: JSONPathParser = {
const contentDefault = { text: '' }
const selectionDefault = undefined
const readOnlyDefault = false
const indentationDefault = 2
const tabSizeDefault = 4
const modeDefault = Mode.tree
const mainMenuBarDefault = true
const navigationBarDefault = true
const statusBarDefault = true
const askToFormatDefault = true
const escapeControlCharactersDefault = false
const escapeUnicodeCharactersDefault = false
const flattenColumnsDefault = true
const parserDefault = JSON
const validatorDefault = undefined
const validationParserDefault = JSON
const pathParserDefault = {
parse: parseJSONPath,
stringify: stringifyJSONPath
}
export let queryLanguages: QueryLanguage[] = [jsonQueryLanguage]
export let queryLanguageId: string = queryLanguages[0].id
export let onChangeQueryLanguage: OnChangeQueryLanguage = noop
export let onChange: OnChange | undefined = undefined
export let onSelect: OnSelect | undefined = undefined
export let onRenderValue: OnRenderValue = renderValue
export let onClassName: OnClassName = () => undefined
export let onRenderMenu: OnRenderMenu = noop
export let onRenderContextMenu: OnRenderContextMenu = noop
export let onChangeMode: OnChangeMode = noop
export let onError: OnError = (err) => {
const queryLanguagesDefault = [jsonQueryLanguage]
const queryLanguageIdDefault = queryLanguagesDefault[0].id
const onChangeQueryLanguageDefault = noop
const onChangeDefault = undefined
const onSelectDefault = undefined
const onRenderValueDefault = renderValue
const onClassNameDefault = noop
const onRenderMenuDefault = noop
const onRenderContextMenuDefault = noop
const onChangeModeDefault = noop
const onErrorDefault: OnError = (err) => {
console.error(err)
alert(err.toString()) // TODO: create a nice alert modal
}
export let onFocus: OnFocus = noop
export let onBlur: OnBlur = noop
const onFocusDefault = noop
const onBlurDefault = noop
export let content: Content = contentDefault
export let selection: JSONEditorSelection | undefined = selectionDefault
export let readOnly: boolean = readOnlyDefault
export let indentation: number | string = indentationDefault
export let tabSize: number = tabSizeDefault
export let mode: Mode = modeDefault
export let mainMenuBar: boolean = mainMenuBarDefault
export let navigationBar: boolean = navigationBarDefault
export let statusBar: boolean = statusBarDefault
export let askToFormat: boolean = askToFormatDefault
export let escapeControlCharacters: boolean = escapeControlCharactersDefault
export let escapeUnicodeCharacters: boolean = escapeUnicodeCharactersDefault
export let flattenColumns: boolean = flattenColumnsDefault
export let parser: JSONParser = parserDefault
export let validator: Validator | undefined = validatorDefault
export let validationParser: JSONParser = validationParserDefault
export let pathParser: JSONPathParser = pathParserDefault
export let queryLanguages: QueryLanguage[] = queryLanguagesDefault
export let queryLanguageId: string = queryLanguageIdDefault
export let onChangeQueryLanguage: OnChangeQueryLanguage = onChangeQueryLanguageDefault
export let onChange: OnChange | undefined = onChangeDefault
export let onSelect: OnSelect | undefined = onSelectDefault
export let onRenderValue: OnRenderValue = onRenderValueDefault
export let onClassName: OnClassName = onClassNameDefault
export let onRenderMenu: OnRenderMenu = onRenderMenuDefault
export let onRenderContextMenu: OnRenderContextMenu = onRenderContextMenuDefault
export let onChangeMode: OnChangeMode = onChangeModeDefault
export let onError: OnError = onErrorDefault
export let onFocus: OnFocus = onFocusDefault
export let onBlur: OnBlur = onBlurDefault
let instanceId = uniqueId()
let hasFocus = false
Expand Down Expand Up @@ -268,9 +296,111 @@
}
export async function updateProps(props: JSONEditorPropsOptional): Promise<void> {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
this.$set(props)
const names = Object.keys(props) as (keyof JSONEditorPropsOptional)[]
for (const name of names) {
switch (name) {
case 'content':
content = props[name] ?? contentDefault
break
case 'readOnly':
readOnly = props[name] ?? readOnlyDefault
break
case 'indentation':
indentation = props[name] ?? indentationDefault
break
case 'tabSize':
tabSize = props[name] ?? tabSizeDefault
break
case 'mode':
mode = props[name] ?? modeDefault
break
case 'mainMenuBar':
mainMenuBar = props[name] ?? mainMenuBarDefault
break
case 'navigationBar':
navigationBar = props[name] ?? navigationBarDefault
break
case 'statusBar':
statusBar = props[name] ?? statusBarDefault
break
case 'askToFormat':
askToFormat = props[name] ?? askToFormatDefault
break
case 'escapeControlCharacters':
escapeControlCharacters = props[name] ?? escapeControlCharactersDefault
break
case 'escapeUnicodeCharacters':
escapeUnicodeCharacters = props[name] ?? escapeUnicodeCharactersDefault
break
case 'flattenColumns':
flattenColumns = props[name] ?? flattenColumnsDefault
break
case 'parser':
parser = props[name] ?? parserDefault
break
case 'validator':
validator = props[name] ?? validatorDefault
break
case 'validationParser':
validationParser = props[name] ?? validationParserDefault
break
case 'pathParser':
pathParser = props[name] ?? pathParserDefault
break
case 'queryLanguages':
queryLanguages = props[name] ?? queryLanguagesDefault
break
case 'queryLanguageId':
queryLanguageId = props[name] ?? queryLanguageIdDefault
break
case 'onChangeQueryLanguage':
onChangeQueryLanguage = props[name] ?? onChangeQueryLanguageDefault
break
case 'onChange':
onChange = props[name] ?? onChangeDefault
break
case 'onRenderValue':
onRenderValue = props[name] ?? onRenderValueDefault
break
case 'onClassName':
onClassName = props[name] ?? onClassNameDefault
break
case 'onRenderMenu':
onRenderMenu = props[name] ?? onRenderMenuDefault
break
case 'onRenderContextMenu':
onRenderContextMenu = props[name] ?? onRenderContextMenuDefault
break
case 'onChangeMode':
onChangeMode = props[name] ?? onChangeModeDefault
break
case 'onSelect':
onSelect = props[name] ?? onSelectDefault
break
case 'onError':
onError = props[name] ?? onErrorDefault
break
case 'onFocus':
onFocus = props[name] ?? onFocusDefault
break
case 'onBlur':
onBlur = props[name] ?? onBlurDefault
break
default:
// We should never reach this default case
return exhaustiveGuard(name)
}
}
if (!queryLanguages.some((queryLanguage) => queryLanguage.id === queryLanguageId)) {
queryLanguageId = queryLanguages[0].id
}
function exhaustiveGuard(name: never): never {
throw new Error(`Unknown property "${name}"`)
}
await tick() // await rerender
}
Expand Down

0 comments on commit 3a2664c

Please sign in to comment.