Fix #1808: toNumber() not working on a unitless unit
#1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is a proper fix. We do need to allow unitless units. If you divide one unit by another having the same dimension, the result will be unitless. Implicitly casting that to a |
|
Ah, of course, that makes sense 👍 . Thanks for your quick response Eric. |
josdejong
added a commit
that referenced
this pull request
May 6, 2020
* Update devDependencies * Fixed `eigs` not using `config.epsilon` (see #1789) * Should be able to take NAMED_DELIMITER as object keys (#1798) Co-authored-by: Jos de Jong <[email protected]> * Update history * Clarify the documentation on `scope` when using `rawArgs`, see #1055 * Bump @babel/preset-env from 7.9.0 to 7.9.5 (#1810) Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.9.0 to 7.9.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.9.0...v7.9.5) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Prefix the cli test with 'node' so it works on windows (#1807) * Prefix the cli test with 'node' so it works on windows Shouldnt provide any issues for other systems I hope * Revert "Prefix the cli test with 'node' so it works on windows" This reverts commit 4cd2704. * Revert "Revert "Prefix the cli test with 'node' so it works on windows"" This reverts commit 268b594. Co-authored-by: Jos de Jong <[email protected]> * Fix #1808: `toNumber()` not working on a unitless unit (#1811) * Update history * Fix #1813: bug in engineering notation for numbers of function `format`, sometimes resulting in needless trailing zeros * Improve explanation of engineering notation in function format * Publish v6.6.3 * Bump uglify-js from 3.8.1 to 3.9.0 (#1816) Bumps [uglify-js](https://github.com/mishoo/UglifyJS2) from 3.8.1 to 3.9.0. - [Release notes](https://github.com/mishoo/UglifyJS2/releases) - [Commits](mishoo/UglifyJS@v3.8.1...v3.9.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Publish v6.6.4 * Bump uglify-js from 3.9.0 to 3.9.1 (#1818) Bumps [uglify-js](https://github.com/mishoo/UglifyJS2) from 3.9.0 to 3.9.1. - [Release notes](https://github.com/mishoo/UglifyJS2/releases) - [Commits](mishoo/UglifyJS@v3.9.0...v3.9.1) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump karma from 4.4.1 to 5.0.3 (#1830) Bumps [karma](https://github.com/karma-runner/karma) from 4.4.1 to 5.0.3. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v4.4.1...v5.0.3) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump karma-mocha from 1.3.0 to 2.0.1 (#1832) * Bump karma from 5.0.3 to 5.0.4 (#1839) Bumps [karma](https://github.com/karma-runner/karma) from 5.0.3 to 5.0.4. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v5.0.3...v5.0.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump mocha from 7.1.1 to 7.1.2 (#1827) * Update devDependencies * Fix #1834: value `Infinity` cannot be serialized and deserialized * Fix broken bundle tests and linting issues * Fix unit test on node 8 (yeah, I know) * Fix #1842: value `Infinity` not turned into the latex symbol `\\infty` * Publish v6.6.5 * Fix fixer.io example, the free plan doesn't support SSL * Change node versions Co-authored-by: jos <[email protected]> Co-authored-by: Veeloxfire <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1808
@ericman314 is this a proper fix? Or should we not allow unitless units in the first place?